Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.c #431

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Update config.c #431

merged 2 commits into from
Dec 14, 2018

Conversation

r00t0vi4
Copy link
Contributor

getpath function contained hardcoded "PIDFILE" value

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10

@DL6ER
Copy link
Member

DL6ER commented Dec 12, 2018

Please point your PR against the development branch and re-open it afterwards.

@DL6ER DL6ER closed this Dec 12, 2018
@DL6ER DL6ER changed the base branch from master to development December 12, 2018 17:11
@DL6ER
Copy link
Member

DL6ER commented Dec 12, 2018

Changed target branch.

@DL6ER DL6ER reopened this Dec 12, 2018
DL6ER
DL6ER previously approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was introduced in e68d82d where it was - at first - harmless, however, as more files were added, e.g., in 4240373, this change became a real bug.

@DL6ER DL6ER added the Bugfix label Dec 12, 2018
@AzureMarker
Copy link
Contributor

The commit requires the DCO signoff. See here for more information: https://docs.pi-hole.net/guides/github/contributing/

@r00t0vi4
Update config.c
dd9b993 
getpath function contained hardcoded "PIDFILE" value

Signed-off-by: r00t0vi4 <r00t0vi4@gmail.com>
DL6ER
DL6ER approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Reapproval was needed due to force-push.

@AzureMarker AzureMarker merged commit d288b7d into pi-hole:development Dec 14, 2018
@r00t0vi4 r00t0vi4 deleted the patch-1 branch December 14, 2018 05:38
DL6ER pushed a commit that referenced this pull request Dec 14, 2018
@AzureMarker @DL6ER
Merge pull request #431 from r00t0vi4/patch-1
634755f 
Update config.c
DL6ER pushed a commit that referenced this pull request Dec 14, 2018
@AzureMarker @DL6ER
Merge pull request #431 from r00t0vi4/patch-1
53a93f7 
Update config.c

Signed-off-by: DL6ER <dl6er@dl6er.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureMarker AzureMarker AzureMarker approved these changes

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r00t0vi4 @DL6ER @AzureMarker