Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new NODATA blocking mode #433

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Add new NODATA blocking mode #433

merged 2 commits into from
Dec 14, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 12, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR add another blocking mode that is reply to each blocked request with no data, i.e., status code NOERROR and empty A and AAAA records. It is unclear if this is advantageous, however, users may want to play around with it.

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added the FTLDNS label Dec 12, 2018
@DL6ER DL6ER added this to the v4.2 milestone Dec 12, 2018
@DL6ER DL6ER requested a review from a team December 12, 2018 17:10
@AzureMarker
Copy link
Contributor

A PR should also be made to https://github.com/pi-hole/docs/

@AzureMarker AzureMarker merged commit 9452664 into development Dec 14, 2018
@AzureMarker AzureMarker deleted the new/NODATA_blocking branch December 14, 2018 00:16
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-v4-2-available-with-shared-memory-new-blocking-modes-and-more/16763/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants