Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for required Linux capabilities #453

Merged
merged 6 commits into from
Jan 4, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 2, 2019

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Add check for required Linux capabilities. Complain loudly when the required capabilities are missing.
Initially, I wanted the check to be fatal, but I know there are many users out there that run pihole-FTL on marginally supported platforms which (partially) don't even support capabilities. Since I don't want them to be unable to start FTL at all, we only log missing capabilities instead of failing hard.

Fixes #432

This template was created based on the work of udemy-dl.

Signed-off-by: DL6ER <dl6er@dl6er.de>
… available

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Jan 2, 2019
@DL6ER DL6ER added this to the v4.3 milestone Jan 2, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
@AzureMarker
Copy link
Contributor

This also updates the docker build containers with the libcap-dev dependency.

@AzureMarker AzureMarker merged commit b07b120 into development Jan 4, 2019
@AzureMarker AzureMarker deleted the new/capabilities_check branch January 4, 2019 20:21
@DL6ER DL6ER mentioned this pull request Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants