Process ARP data for new network table #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmore, we make some database routines globally (add prototypes to routines.h) and mark some internal database variables as static. This commit also improves on the speed of the database routines as the main loop is changed to run from the last saved query to the most recent one instead of looping over all queries in memory. This ID is corrected when queries are removed in gc.c Signed-off-by: DL6ER <dl6er@dl6er.de>
…P cache Signed-off-by: DL6ER <dl6er@dl6er.de>
Print executed SQL statements when in debug mode Signed-off-by: DL6ER <dl6er@dl6er.de>
…e dedicated database thread) Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…e and skip incomplete entires when parsing the ARP cache Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…che() Signed-off-by: DL6ER <dl6er@dl6er.de>
…optional auxiliary file. Signed-off-by: DL6ER <dl6er@dl6er.de>
…test mac->vendor database Signed-off-by: DL6ER <dl6er@dl6er.de>
… used by FTL Signed-off-by: DL6ER <dl6er@dl6er.de>
…n't fail if there was no previous database present Signed-off-by: DL6ER <dl6er@dl6er.de>
…interfere with later INSERT / UPDATE commands Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de> Conflicts: Makefile routines.h
Signed-off-by: DL6ER <dl6er@dl6er.de>
9 tasks
AzureMarker
previously requested changes
Jan 6, 2019
| @@ -319,6 +319,22 @@ void read_FTLconf(void) | |||
| // AUDITLISTFILE | |||
| getpath(fp, "AUDITLISTFILE", "/etc/pihole/auditlog.list", &files.auditlist); | |||
|
|
|||
| // MACVENDORDB | |||
| getpath(fp, "MACVENDORDB", "/etc/pihole/macvendor.db", &FTLfiles.macvendordb); | |||
There was a problem hiding this comment.
Requires documentation update.
AzureMarker
reviewed
Jan 6, 2019
AzureMarker
added a commit
to pi-hole/api
that referenced
this pull request
Jan 6, 2019
Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
reviewed
Jan 7, 2019
… this pointer. Add a callback for the update subroutine. Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
dismissed
AzureMarker’s stale review
Addressed all point except for the documentation (needs to be addressed separately)
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
previously requested changes
Jan 8, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
dismissed
AzureMarker’s stale review
Addressed all point except for the documentation (needs to be addressed separately)
AzureMarker
approved these changes
Jan 9, 2019
AzureMarker
added a commit
to pi-hole/api
that referenced
this pull request
Jan 10, 2019
Update FtlClient struct according to pi-hole/FTL#455
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
Parse ARP information of the device that runs
pihole-FTLand put the information into a new database. Use MAC -> Vendor information if available. We provide the latter information in a separate database that is optional and has to be downloaded by the installer/updater (separate PR on pi-hole/core is in progress).This will update the database to version 3.
The information will be made available on the web interface in the following form (see separate AdminLTE PR for further details):
This template was created based on the work of
udemy-dl.