Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi-hole FTL v4.2.1 #497

Merged
merged 4 commits into from
Feb 7, 2019
Merged

Pi-hole FTL v4.2.1 #497

merged 4 commits into from
Feb 7, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 5, 2019

Release fixing two issues:

  • Blocking status display for NODATA and NXDOMAIN blocking modes
  • File permission issues when using shared memory on systems that lack Linux capabilities support

It also adds in a new feature:

  • Report both the user pihole-FTL started as and the user pihole-FTL crashed as in case it crashes and generated a crash ticket in pihole-FTL.log

…ame up when merging dnsmasq v2.80 in #480

Signed-off-by: DL6ER <dl6er@dl6er.de>
…s support to prevent file access issues and without any "user=..." and "group=..." settings in any dnsmasq config file. This effectively sets the default values for these options to "root". Note that this will not affect the usual Pi-hole operation (where FTL is started as user "pihole") as the user/group dropping is only done if dnsmasq detects that it was started as root (criterion is UID == 0).

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Release label Feb 5, 2019
@DL6ER DL6ER added this to the v4.2.1 milestone Feb 5, 2019
@DL6ER DL6ER requested review from a team February 5, 2019 05:22
AzureMarker
AzureMarker previously approved these changes Feb 5, 2019
Copy link
Contributor

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the only comment I have does not necessarily require change.

dnsmasq/config.h Show resolved Hide resolved
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-v4-2-available-with-shared-memory-new-blocking-modes-and-more/16763/10

@dschaper dschaper merged commit 5f98312 into master Feb 7, 2019
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/hotfix-release-of-pi-hole-v4-2-2/17472/1

@AzureMarker AzureMarker deleted the release/v4.2.1 branch May 18, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants