Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set permissions of database file after creation #587

Merged
merged 10 commits into from
Jun 16, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 10, 2019

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Explicitly set permissions of database files after their creation.

Fixes #586

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added the Bugfix label Jun 10, 2019
@DL6ER DL6ER added this to the v5.0 milestone Jun 10, 2019
…ictive umask on the testing system

Signed-off-by: DL6ER <dl6er@dl6er.de>
…rate PR

Signed-off-by: DL6ER <dl6er@dl6er.de>
…n random data

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Jun 10, 2019

Waiting for #588 to be merged. The ls -l test will need to be changed from root root -> pihole pihole

@DL6ER DL6ER added the WIP label Jun 10, 2019
database.c Outdated Show resolved Hide resolved
…sufficient but the user pihole-FTL is started by is not the owner

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER marked this pull request as ready for review June 15, 2019 05:54
@DL6ER
Copy link
Member Author

DL6ER commented Jun 15, 2019

This PR is now ready for review and merge.

@DL6ER DL6ER removed the WIP label Jun 15, 2019
@AzureMarker AzureMarker merged commit d16105f into development Jun 16, 2019
@AzureMarker AzureMarker deleted the fix/pihole-FTL.db_mode branch June 16, 2019 03:55
@DL6ER DL6ER mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants