Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config flag REGEX_IGNORECASE #620

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 16, 2019

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Add new config flag REGEX_IGNORECASE that can be enabled to make FTL's regex case insensitive. It defaults to false (legacy behavior).

A documentation update will be added later.

This template was created based on the work of udemy-dl.

…s regex case insensitive. It defaults to false (legacy behavior).

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.0 milestone Jul 16, 2019
@DL6ER DL6ER requested a review from a team July 16, 2019 20:57
AzureMarker
AzureMarker previously approved these changes Jul 17, 2019
src/config.c Outdated Show resolved Hide resolved
… (even though this has no effect because everything that is not "true" (case insensitive) is considered false by FTL).

Signed-off-by: DL6ER <dl6er@dl6er.de>
@AzureMarker AzureMarker merged commit 79bbf39 into development Jul 18, 2019
@AzureMarker AzureMarker deleted the new/regex_case_insensitive branch July 18, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants