Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal DNS cache twist #681

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 27, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Do not block queries when a domain is known to be blocked, however, the entire CNAME chain is to be permitted.

This should fix a bug reported on Discourse, waiting on conformation it fixes the issue before switching this PR to live.

…he entire CNAME chain is to be permitted.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Jan 27, 2020
@DL6ER DL6ER added this to the v5.0 milestone Jan 27, 2020
@DL6ER DL6ER requested a review from a team January 27, 2020 21:49
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/some-domains-are-intermittently-blocked-even-though-they-are-on-the-whitelist/27477/10

@dschaper dschaper self-requested a review January 27, 2020 22:13
@DL6ER DL6ER marked this pull request as ready for review January 27, 2020 22:28
@DL6ER
Copy link
Member Author

DL6ER commented Jan 27, 2020

Fix confirmed working by original bug reporter on Discourse

@dschaper dschaper merged commit 9a5a941 into release/v5.0 Jan 27, 2020
@dschaper dschaper deleted the fix/deeply_whitelisted_domain branch January 27, 2020 22:52
Copy link
Member

@dschaper dschaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was approved anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants