Improvements to deep CNAME inspection data processing #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EX_CNAME, QUERY_BLACKLIST_CNAME] and store domain that was the reason for blocking during a CNAME inspection Signed-off-by: DL6ER <dl6er@dl6er.de>
…EX_CNAME, QUERY_BLACKLIST_CNAME] and store domain that was the reason for blocking during a CNAME inspection Signed-off-by: DL6ER <dl6er@dl6er.de>
8 tasks
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/please-explain-difference-in-blocking-ipv4-and-ipv6/27475/91 |
dschaper
previously approved these changes
Feb 3, 2020
DL6ER
force-pushed
the
new/CNAME_inspection_details
branch
from
ab2d1b0
to
336ffc1
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
new/CNAME_inspection_details
branch
from
336ffc1
to
5c08c56
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/request-show-regex-responsible-for-blocking/27656/30 |
… into new/CNAME_inspection_details Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
dschaper
approved these changes
Feb 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Add new CNAME-specific blocking modes
QUERY_GRAVITY_CNAME,QUERY_REGEX_CNAME, andQUERY_BLACKLIST_CNAME.Also, store the domain that was the reason for blocking during a CNAME inspection so it can be shown in the Query Log on the web interface (pi-hole/web#1144):