Internal resolver tweaks #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TL forcing itself as the first resolver of the system Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/ptr-lookups-for-docker-networks/28753/15 |
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
Updated description. |
dschaper
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
In order to be able to resolve host names specified in Custom DNS,
/etc/hosts, etc. we have to ask FTL itself when trying to find out host names to IP addresses by generating PTR requests for this. Previously, this was automatically done, however, with the removal of forcing the local nameserver to127.0.0.1we lost the ability to resolve only locally known host names temporarily. We reinstalled the ability by forcing FTL as the first resolver on the system. As this effectively overwrote/etc/resolv.conf(even if only inside FTL itself), it had adverse effect on docker instances where local name resolution failed for some special devices.This PR addresses the issue in a (user-confirmed) docker-friendly way by adding FTL as last resolver.