Add all clients FTL knows about to the network table #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a yet to be done modification to the web interface to hide the mock hardware addresses we generate for these devices. Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…debugging output to ARP processing. Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
new/all_clients_network_table
branch
from
ac66264
to
ada1274
Compare
…n the last 24 hours. Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
new/all_clients_network_table
branch
from
ada1274
to
1caf634
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
…ree SQL query. Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/long-term-data-weirdness/29308/17 |
Signed-off-by: DL6ER <dl6er@dl6er.de>
…TALE. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This PR also adds host name validation (length & valid characters) to FTL |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/long-term-data-weirdness/29308/30 |
Signed-off-by: DL6ER <dl6er@dl6er.de>
…when we gather ARP/neigh information about them. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
PromoFaux
approved these changes
Mar 29, 2020
3 tasks
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Add all clients FTL knows about to the network table. This requires a yet to be done modification to the web interface to hide the mock hardware addresses we generate for these devices.
This change will import distant clients not visible over ARP/neigh (like VPN connected or VLAN separated devices) in the network table. As there is no one unique identification criterion now (we used the MAC address for this, before), each IP change of a non-deterministic DHCP server will fill the network table with additional entries as there is no way to detect if client
.3was.5yesterday without the MAC address.Maybe we need a setting for this defaulting to
falsewhich can then be enabled by power-users running VPNs, VLANs, etc. However, "normal" (as in: no power-) users will likely not have any clients in their network which are not also covered by ARP/neigh, so there may be no issue even with having this defaulting totrue.Note that clients found through ARP/neigh will always have higher priority than "remaining" clients known to FTL. FTL's knowledge is only used to "fill the gaps".