…ment removes the fixed buffer we used before and allows for responses having arbitraty lengths

…to decide whether the output whould be in telnet format, or JSON (possibly even "v2" JSON)

Currently using the cJSON library, as it's entirely contained
within one source and one header file and is very easy to use.
By adding on the API output formats to the previous raw socket
code, we can simply change the output format when the response
type is `API` instead of `SOCKET`. As shown in the implemented
summary API code, this should be very simple for most commands.

…r into process_api_request() (request.c) much like we already do it for socket requests

…and http://pi.hole/admin/api.php?overTimeData10mins give identical results

…e by reverting this commit.

Also make query types output more like the other responses.

…the whole header was analyzed), 2. Anaylze passed GET arguments properly, e.g. allow ?limit=123, but ignore ?sfqw=123

…ng to RFC 2616)

…me/graphs"

…o we should just return an empty array.

…e predefined constants for the location of the white- and blacklist so they can easily be changed in one place, if needed.

…d a fixed size buffer

The function strcspn() counts the number of characters until it hits a '\r' or a '\n' (in other words, it finds the first '\r' or '\n').
If it doesn't hit anything, it stops at the '\0' (returning the length of the string).
Note that this works fine even if there is no newline, because strcspn stops at a '\0'.
In that case, the entire line is simply replacing '\0' with '\0'.

Previously, both `forward_dest` and `forward_destinations` were keys in the JSON output at the root level. Which contains the over time data, and which contains the forward destination hostnames + IP addresses? Because of this ambiguity, the over time section should be renamed to `over_time`.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Conflicts:
	request.c

If it's `top_ads`, give `ads_blocked_today`. If it's `top_domains`, give `dns_queries_tdoay`. Both are not needed at the same time.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

It's returning one graph, not multiple.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

It provides stats more than DNS functionality. However, it is in more of a gray area than, say, queries over time.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

As this is also shown on chronometer, it seems to be related to stats more than anything else.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

This will have to be extended to the other domain-emitting API calls in future commits.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

This reverts commit 0a6f5a5
The sanitizing will instead be implemented off of dev in the log parsing section.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

…r the API component) accordingly.

Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Uses cJSON to parse, but output will still be handled directly.
I implemented different API response methods to allow for different HTTP
response codes to be sent.
The addList code is still dumb and doesn't do anything, but it's getting
there.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

This requires the `pihole` user to have sudo access to the `pihole`
command (will require a core update). Many future API commands will have
this requirement, as they too will be using the `pihole` command.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

# Conflicts:
#	request.c
#	test/test_suite.sh

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

They were using the missing `swrite` function.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>

Currently has the hardcoded password of "password". You gain a session
by sending JSON to the API with the key of `password` and the value
set to the password you are trying to use. Then it will return a success
response with the session and will add a Set-Cookie header to set the
FTL_SESSION cookie to the session number.

The summary, queries graph, and status are accessible without
authentication.

The internal data structure used to store the sessions is valid for up
to 24 minutes after the last query. If it becomes invalid then it is
eligible to be reused for a new session. The garbage collection can be
optimized further, but it is not a problem at the moment.

Signed-off-by: Mcat12 <newtoncat12@yahoo.com>