Process cached SRV records #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This bug fix has been confirmed working. |
PromoFaux
approved these changes
Jun 3, 2020
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
|
SRV lookup is still broken for me in 5.1 |
|
@undesiredpopup The issue you're seeing is unrelated to this PR. I moved your comment into a new issue ticket and replied there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
dnsmasqadded caching forSRVrecords. As FTL wasn't aware of this new type of cache records, it displayed query response "Unknown (0)" for cached SRV records (the first query, which was forwarded, did show the correct status).As this was missing, it gave rise to a few bug reports, e.g.,
This PR adds analysis capabilities for cache
SRVrecords to resolve these issues.