Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no/false and yes/true for all config options. #796

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 27, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


See title. This improves consistency.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.1 milestone May 27, 2020
@DL6ER DL6ER requested a review from a team May 27, 2020 18:14
@PromoFaux PromoFaux merged commit 0671eb5 into development Jun 3, 2020
@PromoFaux PromoFaux deleted the tweak/config_yes_no_true_false branch June 3, 2020 19:47
@DL6ER DL6ER mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants