Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze EDNS(0) records #851

Merged
merged 18 commits into from
Aug 10, 2020
Merged

Analyze EDNS(0) records #851

merged 18 commits into from
Aug 10, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 21, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Analyze EDNS(0) records. We are especially interested in the Client Subnet feature to obtain client IPs even if they are hidden behind the NAT of a router. See the referenced Discourse discussion for further (technical) details.

@DL6ER DL6ER added this to the v5.3 milestone Jul 21, 2020
@DL6ER DL6ER requested review from PromoFaux and dschaper July 21, 2020 18:48
@DL6ER DL6ER marked this pull request as ready for review August 10, 2020 20:48
Signed-off-by: DL6ER <dl6er@dl6er.de>
…rmation

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
… EDNS(0) payload

Signed-off-by: DL6ER <dl6er@dl6er.de>
…add-mac=base64)

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…okie. Simulate the same with +ednsopt

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Aug 10, 2020

Rebased on latest development

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/support-for-add-subnet-option-from-dnsmasq-ecs-edns0-client-subnet/35940/39

@DL6ER DL6ER merged commit 1124f25 into development Aug 10, 2020
@DL6ER DL6ER deleted the new/edns0 branch August 10, 2020 22:03
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

honigpferd added a commit to honigpferd/nginx-dns that referenced this pull request Jan 8, 2024
Add client ip as ECS param in EDNS(0).
This provides useful in combination with
Pi-hole (R) detecting clients by ECS.

see also pi-hole/FTL#851
see rfc7871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants