Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show also IPv6 nameservers in DEBUG_RESOLVER #866

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Aug 16, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Show also possible IPv6 name servers when DEBUG_RESOLVER is enabled. They are stored in a somewhat auxiliary (external) structure so they were not included in FTL's debug outputs even when they were used during resolving host names. Hence, this PR is a purely cosmetic change without any effect on the functionality. Without DEBUG_RESOLVER being enabled, the changed printing routine is never called.

Before:

[2020-08-16 21:15:52.793 21996/T22008] Trying to resolve 127.0.0.2
[2020-08-16 21:15:52.793 21996/T22008] Using nameservers:
[2020-08-16 21:15:52.793 21996/T22008]  0: 127.0.0.1:53 (IPv4)
[2020-08-16 21:15:52.793 21996/T22008]  1: 0.0.0.0:0 (IPv4)
[2020-08-16 21:15:52.793 21996/T22008]  2: 0.0.0.0:0 (IPv4)

Now:

[2020-08-16 21:15:52.793 21996/T22008] Trying to resolve 127.0.0.2
[2020-08-16 21:15:52.793 21996/T22008] Using nameservers:
[2020-08-16 21:15:52.793 21996/T22008]  0: 127.0.0.1:53 (IPv4)
[2020-08-16 21:15:52.793 21996/T22008]  1: 0.0.0.0:0 (IPv4)
[2020-08-16 21:15:52.793 21996/T22008]  2: 0.0.0.0:0 (IPv4)
[2020-08-16 21:15:52.793 21996/T22008]  3: 0.0.0.0:53 (IPv4)
[2020-08-16 21:15:52.793 21996/T22008]  4: ::1:53 (IPv6)
[2020-08-16 21:15:52.793 21996/T22008]  5: fe80::2aea:17ff:44a3:160d:53 (IPv6)

…(external) structure so they were not included in the debug outputs (even when they were used)

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team August 16, 2020 19:18
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/force-update-of-ip-hostname-clientname-relationship/36585/54

@DL6ER DL6ER merged commit 511b6d9 into development Aug 21, 2020
@DL6ER DL6ER deleted the tweak/debugging_show_IPv6_nameservers branch August 21, 2020 07:08
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants