Allocate shared memory instead of only reserving it #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Use
fallocate()
instead offtruncate()
when resizing and/or creating shared memory objects.This ensures we reserve the requested memory exclusively for ourselves. With
ftruncate
we only announce we want the memory, however, other processes can still take the memory when the/dev/shm
is close to being full.This has the effect that this PR ensures that FTL does not crash when
/dev/shm
is getting full.In addition, even when the shared memory arena is full, there will be a better error message, like