Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-compiled ARMv4, ARMv5 and ARMv8 binaries to CI workflow #903

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 14, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Add additional

  • ARMv4 (armv4t, 3-stage pipeline, Thumb, ARMv4 first to drop legacy ARM 26-bit addressing),
  • ARMv5 (armv5te, Thumb, enhanced DSP instructions, caches), and
  • ARMv8 (armv8-a, fundamental change to the ARM architecture with mandatory vector floating point and SIMD (Neon))

workflows.

  • ARMv6 (with hard-float, for Raspberry Pi Model 1 and Zero), and
  • ARMv7 (with hard-float, for Raspberry Pi Model 2)

already exist and have just been renamed to clarify the supported architecture.

…ponding binaries

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Oct 14, 2020

@pi-hole/api-approvers We need to overwrite CircleCI tests on this one as it is still expecting the old build names. If you scroll down, you can see that all the new builds are ✔️

@DL6ER DL6ER added the PR: Approval Required Open Pull Request, needs approval label Oct 14, 2020
@dschaper
Copy link
Member

Updated development branch to only require the build step of CI. It will fail if any of the associated steps fail so no need to have every binary checked for merge.

@DL6ER DL6ER merged commit f69dab5 into development Oct 18, 2020
@DL6ER DL6ER deleted the new/armv4_armv5 branch October 18, 2020 17:54
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/build-for-pihole-ftl-arm-soft-float/39254/22

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-ftl-for-armv5l-precompiled/32645/2

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants