Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement interrupt-safe systemcalls #969

Merged
merged 26 commits into from
Dec 21, 2020
Merged

Implement interrupt-safe systemcalls #969

merged 26 commits into from
Dec 21, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 9, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10

Implement our own interrupt-safe versions of the following routines:

  • strdup()
  • calloc()
  • realloc()
  • printf()
  • fprintf()
  • vprintf()
  • vfprintf()
  • sprintf()
  • vsprintf()
  • snprintf()
  • vsnprintf()
  • write()
  • accept()
  • recv()
  • recvfrom()
  • sendto()
  • select()
  • pthread_mutex_lock()
  • fopen()

@DL6ER
Rename memory.c -> syscalls.c
7459d82 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Factor out syscalls for calloc, free, realloc and strdup into dedicat…
d4deb01 
…ed syscalls/{}.c files

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe fprintf() and printf() routines
9537d7d 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe vfprintf() and vprintf() routines
217f957 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Make calloc(), realloc() and strdup() interrupt-safe
44f88e8 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe write() routine
1a0df27 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe accept() routine
e23eb12 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Avoid redundant error reporting
06396ba 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Improve printf(), fprintf(), vprintf(), and vfprintf() error reporting
b00548e 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe recv() routine
69ec44c 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe recvfrom() routine
3dfc069 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe pthread_mutex_lock() routine
2c35038 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe select() routine
ffdc52a 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe fopen() routine
67b1a65 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe sendto() routine
543ea85 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Backup and restore errno in real-time signal handler.
d234dad 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe vsnprintf() routine
d4d4a0b 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe snprintf() routine
70a4ad1 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe vsprintf() routine
20fa5ef 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Add interrupt-safe sprintf() routine
ab0daeb 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Dec 9, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftlv5-3-2-engine-crash/41392/9

@DL6ER
Add interrupt-safe asprintf() and vasprintf() routines
85c8af4 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER mentioned this pull request Dec 17, 2020
Closed
@DL6ER
Add interrupt-safe fallocate() routine, due to the special nature of …
fd78858 
…the fallocate() macro, we hav to use a modified name fTLallocate() to implement this function

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Prevent possible deadlock if log is not writable (e.g., permission de…
9627ca6 
…nied)

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Don't fail when trying to free(NULL)
f88b149 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Fix Unix socket error handling
b52eb1f 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Do not print user change information if there is no user change
0837b8d 
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER mentioned this pull request Dec 20, 2020
Merged
5 tasks
@DL6ER DL6ER marked this pull request as ready for review December 20, 2020 11:33
@DL6ER
Copy link
Member Author

DL6ER commented Dec 20, 2020

Ready for review/testing. The proper function of this branch has been mentioned in a few issue tickets all over the place in this repository.

The merge conflict will be resolved when merging #991 (this PR adds a better solution to the same problem).

@DL6ER DL6ER added the PR: Approval Required Open Pull Request, needs approval label Dec 20, 2020
@dschaper dschaper added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Dec 20, 2020
@DL6ER DL6ER merged commit 4cd9353 into development Dec 21, 2020
@DL6ER DL6ER deleted the tweak/interruptsafe_systemcalls branch December 21, 2020 09:05
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/ftlv5-3-2-engine-crash/41392/15

@DL6ER DL6ER mentioned this pull request Dec 23, 2020
Merged
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-2-and-ftl-v5-3-3-released/41998/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschaper dschaper dschaper approved these changes

@PromoFaux PromoFaux Awaiting requested review from PromoFaux

Assignees
No one assigned
Labels
Bugfix PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DL6ER @pralor-bot @dschaper