Add UNKNOWN option for REFRESH_HOSTNAME #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive clients with unknown hostnames Signed-off-by: DL6ER <dl6er@dl6er.de>
… on receipt of SIGRT4 Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
PromoFaux
reviewed
Dec 17, 2020
Co-authored-by: Adam Warner <me@adamwarner.co.uk>
PromoFaux
approved these changes
Dec 23, 2020
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-2-and-ftl-v5-3-3-released/41998/1 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
This PR adds the new parameter
REFRESH_HOSTNAMES=UNKNOWNto support only refreshing recently active clients without hostnames.There will be no PTR queries made for clients where hostnames are known. This also means that known hostnames will never be updated. This is intentional for this option. Other behavior can be achieved with the other available values for this config option.
In addition, we improve the behavior of real-time signal 4: Whenever the signal is arrived, we force a hostname renewal for all clients matching the current
REFRESH_HOSTNAMESsetting. "Forcing" in this context means that the "only resolve recently active clients" rule is ignored.