Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reduce flickering #300

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Try to reduce flickering #300

merged 1 commit into from
Dec 17, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 17, 2022

What does this PR aim to accomplish?:

The major redesign of the way the dashboard is printed (#268) has introduced flickering on external displays (#290).

This PR is fixing this in two ways:

  1. Use tput instead of stty to obtain the amount of rows and columns after a window resize. (The idea was to use stty because it has less overhead and is faster than tput).
  2. The whole screen is not erased anymore before each refresh, but only when the window is resized.

Fixes #290 and #288


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team December 17, 2022 12:44
@yubiuser yubiuser merged commit cfca04c into development Dec 17, 2022
@yubiuser yubiuser deleted the no_flicker branch December 17, 2022 12:45
@yubiuser yubiuser mentioned this pull request Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants