Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
We use
GetFTLData "dns-port"
to figure out the DNS portFTL
is listening on.PADD/padd.sh
Line 423 in 1cf30ee
This port can be
0
if the DNS function of the internaldnsmasq
is disabled. (https://docs.pi-hole.net/ftldns/telnet-api/#dns-port)However, we use
0
withinGetFTLData()
, to signal an error when we fail to get the telnet API port (for whatever reason)PADD/padd.sh
Lines 114 to 124 in 1cf30ee
We should not use a number as return code that could have another meaning. As
GetFTLData "dns-port"
is the only place we actually checked for0
(read as: we never checked anywhere else) I removed the code to signal a failure on getting the API port.Issue discovered in #307. (This PR won't fix the issue, but can help to improve investigation)
By submitting this pull request, I confirm the following:
git rebase
)