Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify log message for missing caps #1687

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

jnodorp
Copy link
Contributor

@jnodorp jnodorp commented Feb 8, 2025

Description

Changed warning to error.

Motivation and Context

Confusing container exit without errors.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@yubiuser
Copy link
Member

yubiuser commented Feb 8, 2025

I think I don't understand your motivation. Without the capabilities, FTL would not run anyway - why not stop the container already at startup then?

@rdwebdesign
Copy link
Member

Running the container without capabilities is not possible.

This is exactly why we should exit in case the system is unable to set capabilities. The container will fail anyway.

Signed-off-by: Julian Nodorp <6053734+jnodorp@users.noreply.github.com>
@jnodorp jnodorp changed the title Do not fail with cap warning Clarify log message for missing caps Feb 8, 2025
@jnodorp
Copy link
Contributor Author

jnodorp commented Feb 8, 2025

Sorry, just started out w/ pihole. Then the bug is the warning vs. error message. I updated the PR accordingly.

Having the container exit (seemingly) without an error was confusing.

@yubiuser yubiuser merged commit 164cf4a into pi-hole:development Feb 8, 2025
6 checks passed
@jnodorp jnodorp deleted the patch-1 branch February 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants