-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease of FTLDNS image #289
Conversation
Available test images:
|
Reminder: contingent on the next release not using block pages, but NULL DNS responses by default, I may remove the validation of "ServerIP" being set and exiting the container startup when not set since it will not be required anymore. Perhaps I'll add a 'BlockMode=X' env, when when set to 'Page' requires ServerIP also, but when set to 'Null' ServerIP would not be required. |
Signed-off-by: Adam Hill <adam@diginc.us>
Looks like some of the default behaviour like grabbing and updating the default adlists doesn't work in this pre-release, not sure if that's by design or an oversight. I also noticed that when updating the Top Domains and Top Clients list within the API/Web Interface location that dnsmasq errors would pop up, it looks like it was attempt to start up a seperate instance of dnsmasq when these were updated. Restarting the container would resolve the error being thrown. Happy to run it for longer and provide other feedback if necessary. |
Signed-off-by: Adam Hill <adam@diginc.us>
There are no adlists by default in the new FTLDNS pi-hole installer, there is a prompt for users to select the current 'recommended' ones they want to opt into. I haven't made an equivalent way for users to opt-in to the lists of ads. I'll add something for this and do more checking on the updating. Once the lists are selected they seemed to update OK during container startup and the web interface, I'm just re-using my old 3.3.1 container volume data to seed the lists in all real world tests so far though. I saw the pihole-FTL restart errors too, I am pushing a fix for those now. |
I had previously specified the dns server for the pi-hole container as Few other issues I seem to encounter with the new version:
All the other features seem to more or less work appropriately with my limited testing. EDIT: Seems the first issue with the Query Log might have been related to the my setup specifically with DNSSEC. |
Also noticed that the both Query Types and Queries answered by pie charts on the Dashboard appear to have missing pieces. You can see here what I mean. Again could be unrelated but that doesn't seem to be an issue on the main release. Happy to lodge this upstream if you're experiencing the same problem. EDIT: The graphing problem was related to the browser cache, clearing this sorted this one out. Have you noticed much of a difference in memory consumption with the FTLDNS branch? |
* Removed some old switch statements from alpine no longer required * Limit parallel tests to 2 to help prevent test failure caused by race condition starting parallel tests/containers * Began introducing a new ENV NO_SETUP to skip the majority of startup script 'setup' functions eventually Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Moving this branch to match pi-hole's release branch name scheme (release/v4.0) and made a new pull request: #300 |
Description
Pi-Hole FTLDNS pre release changes
Motivation and Context
Prep work to confirm the image is ready for FTLDNS
How Has This Been Tested?
pytests updated. Running resulting image for personal use.
Types of changes
New version!
Checklist: