Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo naming changes #302

Merged
merged 15 commits into from
Aug 4, 2018
Merged

Repo naming changes #302

merged 15 commits into from
Aug 4, 2018

Conversation

diginc
Copy link
Collaborator

@diginc diginc commented Aug 4, 2018

resolves #301

There were also a bunch of remnants of Alpine VS Debian image, and Debian still being in the tag didn't make sense to port over with the repo/org change.

The multi-arch-images are not a seperately named image anymore either since we're not doing a docker inc. 'Automated Build' we do not have restrictions imposed by that anymore. That's not to say this image's build isn't going to be automated, it will be.

Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
@diginc
Copy link
Collaborator Author

diginc commented Aug 4, 2018

Tests are still failing because of debian being in the tags. Having them as regression tests is important during refactoring so I'll address that in this PR too.

E       Failed: Unexpected exit code 125 for CommandResult(command='docker run -d -e ServerIP="1.2.3.4" -e DNS1="1.2.3.4" -e DNS2="2.2.3.4" --dns 127.0.0.1 -v /dev/null:/etc/pihole/adlists.default -e PYTEST="True" pi-hole:debian_amd64 tail -f /dev/null', exit_status=125, stdout=None, stderr="WARNING: Localhost DNS setting (--dns=127.0.0.1) may fail in containers.\nUnable to find image 'pi-hole:debian_amd64' locally\ndocker: Error response from daemon: pull access denied for pi-hole, repository does not exist or may require 'docker login'.\nSee 'docker run --help'.\n")

…ast, starting on new deploy

Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
@diginc diginc merged commit 4dc3c7e into release/v4.0 Aug 4, 2018
@diginc diginc deleted the repo_naming_changes branch August 4, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant