Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented missing support for DNSMASQ_LISTENING environment variable #334

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

dhutchison
Copy link
Contributor

Documentation included reference to a "DNSMASQ_LISTENING" environment variable which could be supplied to the docker container to change the DNSMASQ listening behaviour, this was not implemented in the start script so had not effect. This change implements updating the setupVars configuration file based on the environment variable value.

Description

Change to the setup_dnsmasq function in bash_functions to take an additional parameter for the DNSMASQ_LISTENING environment variable value. If this is a non-empty string the DNSMASQ_LISTENING setting will be written to the setupVars.conf configuration file.

Motivation and Context

Fixes feature noted in the documentation which is missing.

How Has This Been Tested?

Manual testing has been performed against the amd_64 version of the image (changes are version agnostic), checking that the environment variable values of "all" and "local" make the appropriate change to the settings displayed in the "DNS" tab of the admin web interface. Confirmed no environment variable supplied functions as before.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: David Hutchison <dhutchison86+github@googlemail.com>
@diginc diginc merged commit 3870154 into pi-hole:development Oct 27, 2018
@diginc
Copy link
Collaborator

diginc commented Oct 27, 2018

Looks good, Thanks! I didn't quite get where this variable was used at first (thought it was dnsmasq daemon at first). Sorry for the delay. I'll get this built into a dev image right away for you to test.

diginc added a commit that referenced this pull request Oct 30, 2018
Implemented missing support for DNSMASQ_LISTENING environment variable

Signed-off-by: Adam Hill <adam@diginc.us>
@dhutchison dhutchison deleted the development branch December 14, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants