Implemented missing support for DNSMASQ_LISTENING environment variable #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation included reference to a "DNSMASQ_LISTENING" environment variable which could be supplied to the docker container to change the DNSMASQ listening behaviour, this was not implemented in the start script so had not effect. This change implements updating the setupVars configuration file based on the environment variable value.
Description
Change to the setup_dnsmasq function in bash_functions to take an additional parameter for the DNSMASQ_LISTENING environment variable value. If this is a non-empty string the DNSMASQ_LISTENING setting will be written to the setupVars.conf configuration file.
Motivation and Context
Fixes feature noted in the documentation which is missing.
How Has This Been Tested?
Manual testing has been performed against the amd_64 version of the image (changes are version agnostic), checking that the environment variable values of "all" and "local" make the appropriate change to the settings displayed in the "DNS" tab of the admin web interface. Confirmed no environment variable supplied functions as before.
Types of changes
Checklist: