Remove Unneccessary kill -9 #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since piholeFTL test properly spins down it's no longer necessary to kill it. He's dead Jim Merge pi-hole#300, added `piholeFTL test` to the startup sequence to replace dnsmasq as a dependency for validate_env and gravity.sh. kill -9 was kept as a work around to a standing issue that `piholeFTL test` didn't spin down on it's own. This was fixed in pi-hole/FTL#1067, landed on Apr 14 2021 and confirmed working, as evinced by pi-hole#834 which was filed the same day it that fix landed. Signed-off-by: D.Rect <48034372+DistractionRectangle@users.noreply.github.com>
PromoFaux
approved these changes
Aug 3, 2021
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/hotfix-pi-hole-web-v5-5-1-released/48708/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
piholeFTL testproperly spins down it's no longernecessary to kill it. He's dead Jim
Motivation and Context
Merge #300, added
piholeFTL testto the startup sequence toreplace dnsmasq as a dependency for validate_env and gravity.sh.
kill -9 was kept as a work around to a standing issue that
piholeFTL testdidn't spin down on it's own. This was fixedin pi-hole/FTL#1067, landed on Apr 14 2021 and confirmed
working, as evinced by #834 which was filed the same day it
that fix landed.
How Has This Been Tested?
Docker up/down with clean volumes for amd64 and arm to make sure container boots up properly
Types of changes
Checklist: