Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about group assignment of whitelisted/blacklisted d… #694

Merged

Conversation

martinbrose
Copy link
Contributor

@martinbrose martinbrose commented Apr 24, 2022

…omains

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:
Addressing issue pi-hole/pi-hole#4581 by adding additional information about group assignment of whitelisted/blacklisted domains.

How does this PR accomplish the above?:
Added two sentences to guides / misc / whitelist-blacklist.md.

What documentation changes (if any) are needed to support this PR?:
No additional changes necessary. This PR is a documentation change.
No additional comments within the code necessary. Hence, I left the related checkbox empty above.

…omains

Signed-off-by: Martin Brose <13284268+martinbrose@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Apr 24, 2022

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 85152e1
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/626651895900820008acca8f
😎 Deploy Preview https://deploy-preview-694--pihole-docs.netlify.app/guides/misc/whitelist-blacklist
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Martin Brose <13284268+martinbrose@users.noreply.github.com>
Addressed reviewer feedback

Co-authored-by: yubiuser <ckoenig@posteo.de>
@martinbrose
Copy link
Contributor Author

Thanks for your review @yubiuser.
Agreed and changed.

I probably should also slightly change the wording for the related PR pi-hole/web#2186.

@yubiuser yubiuser enabled auto-merge April 25, 2022 11:16
@yubiuser yubiuser merged commit a7342b8 into pi-hole:master Apr 25, 2022
@martinbrose martinbrose deleted the fix-pi-hole-4581-documentation_whitelist branch April 25, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants