Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart apparmor command in unbound.md #959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregbrant2
Copy link

What does this PR aim to accomplish?:

Fixes an error in the Unbound DNS guide which says to restart unbound instead of apparmor.

How does this PR accomplish the above?:

Fixes the typo.

Link documentation PRs if any are needed to support this PR:

N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Greg Brant <54865582+gregbrant2@users.noreply.github.com>
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 2f8760f
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/6565ca0fea078000087fdc79
😎 Deploy Preview https://deploy-preview-959--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DL6ER
Copy link
Member

DL6ER commented Nov 28, 2023

We have sudo apparmor_parser -r /etc/apparmor.d/usr.sbin.unbound immediately preceding which loads (-r = replace) the change into the Linux kernel. The following restart is targeted at unbound as it has to be restarted to be allowed to write to this file afterwards.

I don't think this is a mistake.

@gregbrant2
Copy link
Author

gregbrant2 commented Nov 28, 2023

@DL6ER ah, ok. But then is the sudo service unbound restart on line 273 unnecessary? This is what made me think it's a typo as you're saying to restart unbound twice.

image

@dschaper
Copy link
Member

dschaper commented Dec 2, 2023

Yeah, the unbound service call seems to have been inadvertently duplicated. This is the commit that added the apparmor instructions and I think that's where the code was duplicated. @DL6ER This was yours so I'll let you confirm or deny.

567d813

My suggestion is to remove the line that this PR changes. Leave the unbound restart in the section directly below.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants