Fix the wrong escaping on settings datatable

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
pi-hole · Jan 29, 2022 · 14f3aab · 14f3aab
1 parent a302e9f
commit 14f3aab
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/scripts/pi-hole/js/settings.js b/scripts/pi-hole/js/settings.js
@@ -268,9 +268,22 @@ $(function () {
       columnDefs: [
         { bSortable: false, orderable: false, targets: -1 },
         {
-          targets: [0, 1, 2],
+          targets: [0, 1],
           render: $.fn.dataTable.render.text(),
         },
+        {
+          targets: 2,
+          render: function (data, type, row) {
+            // Show "unknown", when host is "*"
+            if (data == "*") {
+              return "<i>unknown</i>";
+            } else {
+              return typeof data === "string"
+                ? data.replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;")
+                : data;
+            }
+          },
+        },
       ],
       paging: true,
       order: [[2, "asc"]],

diff --git a/settings.php b/settings.php
@@ -595,9 +595,6 @@ function convertseconds($argument)
                                         }
 
                                         $host = htmlentities($line[3]);
-                                        if ($host == "*") {
-                                            $host = "<i>unknown</i>";
-                                        }
 
                                         $clid = $line[4];
                                         if ($clid == "*") {