Don't try to fill client/domain tables if there is no data (#3069)

pi-hole · Jul 8, 2024 · 60ca1c7 · 60ca1c7
2 parents e852fbb + 337d7e5
commit 60ca1c7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/scripts/pi-hole/js/index.js b/scripts/pi-hole/js/index.js
@@ -295,6 +295,8 @@ function updateTopClientsTable(blocked) {
     // Add note if there are no results (e.g. privacy mode enabled)
     if (jQuery.isEmptyObject(data.clients)) {
       clienttable.append('<tr><td colspan="3"><center>- No data -</center></td></tr>');
+      overlay.hide();
+      return;
     }
 
     // Populate table with content
@@ -352,6 +354,8 @@ function updateTopDomainsTable(blocked) {
     // Add note if there are no results (e.g. privacy mode enabled)
     if (jQuery.isEmptyObject(data.domains)) {
       domaintable.append('<tr><td colspan="3"><center>- No data -</center></td></tr>');
+      overlay.hide();
+      return;
     }
 
     // Populate table with content