Escaping only when is necessary

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
pi-hole · Jan 29, 2022 · 61e3ba7 · 61e3ba7
1 parent 4dab7a4
commit 61e3ba7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/scripts/pi-hole/js/settings.js b/scripts/pi-hole/js/settings.js
@@ -276,9 +276,13 @@ $(function () {
           render: function (data, type, row) {
             // Show "unknown", when host is "*"
             if (data == "*") {
-              return '<i>unknown</i>';
+              return "<i>unknown</i>";
             } else {
-              return data;
+              return (
+                typeof data === "string" ?
+                data.replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;") :
+                data
+              );
             }
           },
         },