Skip to content

Commit

Permalink
Address team decisions
Browse files Browse the repository at this point in the history
- change checkboxes order;
- remove all lines if all checkboxes are unselected.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
  • Loading branch information
rdwebdesign committed Sep 9, 2022
1 parent 262a5cd commit 76fa441
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions groups-domains.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,10 @@
<div class="filter_types">
<div class="line">
<span><input type="checkbox" name="typ" value="0" id="typ0" checked><label for="typ0">Exact whitelist</label></span>
<span><input type="checkbox" name="typ" value="1" id="typ1" checked><label for="typ1">Exact blacklist</label></span>
<span><input type="checkbox" name="typ" value="2" id="typ2" checked><label for="typ2">Regex whitelist</label></span>
</div>
<div class="line">
<span><input type="checkbox" name="typ" value="2" id="typ2" checked><label for="typ2">Regex whitelist</label></span>
<span><input type="checkbox" name="typ" value="1" id="typ1" checked><label for="typ1">Exact blacklist</label></span>
<span><input type="checkbox" name="typ" value="3" id="typ3" checked><label for="typ3">Regex blacklist</label></span>
</div>
</div>
Expand Down
4 changes: 0 additions & 4 deletions scripts/pi-hole/js/groups-domains.js
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,6 @@ $.fn.dataTable.ext.search.push(function (settings, searchData, index, rowData) {
})
.get();

if (types.length === 0) {
return true;
}

if (types.indexOf(rowData.type.toString()) !== -1) {
return true;
}
Expand Down

0 comments on commit 76fa441

Please sign in to comment.