Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVCB and HTTPS types #1675

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Add SVCB and HTTPS types #1675

merged 1 commit into from
Jan 13, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 31, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Add SVCB and HTTPS types and reduce code duplication slightly

How does this PR accomplish the above?:

This is the frontend PR corresponding to pi-hole/FTL#1010
This PR works without the FTL changes, however, it also doesn't do anything without them.
(this also means it can be merged independently of the FTL PR).

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/other-query-to-list-as-svcb-https-type/41022/5

@PromoFaux PromoFaux merged commit 136006b into devel Jan 13, 2021
@PromoFaux PromoFaux deleted the new/SVCB_HTTPS branch January 13, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants