Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
Add
SVCB
andHTTPS
types and reduce code duplication slightlyHow does this PR accomplish the above?:
This is the frontend PR corresponding to pi-hole/FTL#1010
This PR works without the FTL changes, however, it also doesn't do anything without them.
(this also means it can be merged independently of the FTL PR).
What documentation changes (if any) are needed to support this PR?:
None