Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove traces of leftover API_PRIVACY_MODE #1943

Merged
merged 2 commits into from
Nov 20, 2021
Merged

Remove traces of leftover API_PRIVACY_MODE #1943

merged 2 commits into from
Nov 20, 2021

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 26, 2021 •
edited
Loading

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Removes traces of the leftover setting API_PRIVACY_MODE.
For details see: #1941

The corresponding change in /pihole is: pi-hole/pi-hole#4413 as this PR is on hold due to internal discussion I cherry-picked the removal of the unused function in pi-hole/pi-hole#4420

@yubiuser
Remove traces of leftover API_PRIVACY_MODE
b5d9908 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Remove 'privacyMode' as well
9ce065f 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser linked an issue Oct 26, 2021 that may be closed by this pull request
Code litter or forgotten setting? #1941
Closed
@yubiuser yubiuser marked this pull request as ready for review October 26, 2021 17:58
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 26, 2021
@yubiuser yubiuser mentioned this pull request Oct 26, 2021
Closed
8 tasks
@yubiuser yubiuser mentioned this pull request Nov 2, 2021
Merged
8 tasks
@yubiuser yubiuser requested a review from a team November 20, 2021 12:49
@DL6ER DL6ER merged commit 18d1588 into devel Nov 20, 2021
@DL6ER DL6ER deleted the remove/API_Privacy_leftover branch November 20, 2021 20:14
@DL6ER DL6ER added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Nov 20, 2021
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
Merged
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

This was referenced Dec 22, 2021
Merged
Merged
Closed
Merged
Merged
This was referenced Jan 3, 2022
Merged
Closed
@renovate renovate bot mentioned this pull request Mar 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code litter or forgotten setting?
3 participants
@yubiuser @pralor-bot @DL6ER