Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying the same colors (CSS colors) used on the dashboard, for consistency. #1992

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Applying the same colors (CSS colors) used on the dashboard, for consistency. #1992

merged 1 commit into from
Dec 2, 2021

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Dec 2, 2021

By submitting this pull request, I confirm the following:

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

The graph on "db_graph.php" has hard-coded colors for the bars, but the dashboard graph uses the CSS theme colors.

On PR #1977, the grid and tick colors were "imported", but bar colors were not.
This PR changes the hard-coded values and uses the CSS colors.

How does this PR accomplish the above?:

Applying the same technique used in the dashboard to import the colors defined via CSS and then use the colors in javascript code.

What documentation changes (if any) are needed to support this PR?:

none.

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@DL6ER DL6ER merged commit 42c3be7 into pi-hole:devel Dec 2, 2021
@rdwebdesign rdwebdesign deleted the bar_colors branch December 2, 2021 20:31
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants