Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving code readability for lists (index.js and db_lists.js) #1994

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Improving code readability for lists (index.js and db_lists.js) #1994

merged 1 commit into from
Dec 18, 2021

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR improves code readability and I think it might make maintenance easier.

How does this PR accomplish the above?:

Two new functions created to simplify the code, reducing the number of concatenations and mixed HTML tags.

What documentation changes (if any) are needed to support this PR?:

none

@yubiuser
Copy link
Member

yubiuser commented Dec 3, 2021

I'm fine with that change but would like to get input from others as it affects how we write and style code.

Relluem94
Relluem94 previously approved these changes Dec 16, 2021
Copy link

@Relluem94 Relluem94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@DL6ER
Copy link
Member

DL6ER commented Dec 18, 2021

I don't really think it affects our styling much. Anything will be rewritten at some, hopefully not even that distant, point.

@yubiuser yubiuser merged commit 7927ac1 into pi-hole:devel Dec 18, 2021
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants