-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize summary numbers #2029
Localize summary numbers #2029
Conversation
…nt- instead of browser-based number localization Signed-off-by: DL6ER <dl6er@dl6er.de>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Can you include a fix for the long-term database as well? At least for me, the percentage got an |
Signed-off-by: DL6ER <dl6er@dl6er.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm working
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-update-reduced-number-of-blocked-domains/52599/11 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/zahlenformat-darstellung-im-dashboard/52657/2 |
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
See title
How does this PR accomplish the above?:
Ensure number formatting is taking place in browser-scope to use client- instead of browser-based number localization. This relies on the locale being correctly applied in the user's browser.
Screenshots
What documentation changes (if any) are needed to support this PR?:
None