-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove text transformation from update command #2037
Conversation
An additional change is needed if the host name should remain capitalized. On the other hand, this fix would improve the readability of host names using camel case. |
This was an intentional design choice. I chose the uppercase, because the original design used uppercase everywhere. I don't know if this should be change only because personal taste. Do you have a reason for this? Can you please explain? |
Host names are not case sensitive, so in my opinion, displaying it in all-caps is fine. However, the update command does not work in all caps, which may confuse inexperienced users. This is why I believe the update command should not be capitalized. Would it be okay to change the capitalization only in the footer? This would be a compromise between design and usability. PS: I mean the capitalization of the code element in the footer, not the whole footer. |
Signed-off-by: Iksas <Iksas@users.noreply.github.com>
f03a07a
to
af4ec2b
Compare
I think this is the best solution (usability is always more important). PS: I don't know if you are aware of this, but text formatted using |
Interesting, I didn't know that. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1 |
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
This PR removes the upper case text transformation from the update command. The resulting change can be seen below:
Only the LCARS theme is affected, because other themes don't use text transformations.
How does this PR accomplish the above?:
The
text-transform
property is set tonone
forcode
elements in the footer.What documentation changes (if any) are needed to support this PR?:
none