Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout on small screens for some datatables #2078

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Avoid the horizontal scrollbar in a few tables, specially on small screens.

How does this PR accomplish the above?:

Applying a new CSS to these tables, transforming the table layout into "cards layout".

What documentation changes (if any) are needed to support this PR?:

none
(maybe some screenshot will need to be updated)

@rdwebdesign rdwebdesign marked this pull request as draft January 14, 2022 03:44
@yubiuser yubiuser marked this pull request as ready for review January 14, 2022 16:08
@yubiuser
Copy link
Member

yubiuser commented Jan 14, 2022

On mobile horizontal orientation
Screenshot_20220114-170756

yubiuser
yubiuser previously approved these changes Jan 14, 2022
yubiuser
yubiuser previously approved these changes Jan 14, 2022
style/pi-hole.css Outdated Show resolved Hide resolved
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@yubiuser yubiuser merged commit 035d8f9 into devel Jan 14, 2022
@yubiuser yubiuser deleted the fix_tbl_small_screens branch January 14, 2022 21:41
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/expand-width-of-type-column-on-grp-mgmt-domains/37887/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants