-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layout on small screens for some datatables #2078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdwebdesign
force-pushed
the
fix_tbl_small_screens
branch
from
January 14, 2022 03:48
63692c9
to
204889d
Compare
yubiuser
previously approved these changes
Jan 14, 2022
3 tasks
yubiuser
previously approved these changes
Jan 14, 2022
yubiuser
reviewed
Jan 14, 2022
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
fix_tbl_small_screens
branch
from
January 14, 2022 20:10
d18c559
to
fcfe806
Compare
yubiuser
approved these changes
Jan 14, 2022
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
This was referenced Feb 12, 2022
Closed
1 task
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/expand-width-of-type-column-on-grp-mgmt-domains/37887/20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Avoid the horizontal scrollbar in a few tables, specially on small screens.
How does this PR accomplish the above?:
Applying a new CSS to these tables, transforming the table layout into "cards layout".
What documentation changes (if any) are needed to support this PR?:
none
(maybe some screenshot will need to be updated)