Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves extension validation for teleporter.php #2087

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix #1455.

The original code assumed that the file extension ".tar.gz" was always after the first dot.

This way, it could accept invalid filenames like:
filename.tar.gz.php

or it could ignore valid filenames like:
file.name.with.dots.tar.gz

How does this PR accomplish the above?:

Changing the code to look for the extension at the end of the filename.

What documentation changes (if any) are needed to support this PR?:

none.

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@yubiuser yubiuser merged commit fe32e57 into devel Jan 17, 2022
@yubiuser yubiuser deleted the fix_extension_check branch January 17, 2022 19:20
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants