Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording of status when blocking is disabled #2136

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Mar 1, 2022

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

When FTL is running, but blocking disabled, the status panel showed "offline". But this is ambiguous: Is FTL offline (hence no DNS resolution at all) or is only the blocking function diabled/offline?

This PR changes the wording to be more clear: only the blocking is disabled.
Bildschirmfoto zu 2022-03-01 13-18-52

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team March 1, 2022 12:22
@yubiuser yubiuser merged commit c610a07 into devel Mar 1, 2022
@yubiuser yubiuser deleted the offline branch March 1, 2022 19:13
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants