Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty array if there is no data #2169

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Return empty array if there is no data #2169

merged 1 commit into from
Apr 13, 2022

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Apr 13, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

This PR returns an empty array if no data is received from the database.

Before this PR: if no data was received nothing would be returned, causing an error.
After this PR: if no data is received, an empty array will be returned and no error message.

How does this PR accomplish the above?:

With a small change to the output.

What documentation changes (if any) are needed to support this PR?:
none

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser yubiuser merged commit 93be8ef into devel Apr 13, 2022
@yubiuser yubiuser deleted the apidb_smallfix branch April 13, 2022 19:24
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants