-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using utils.showAlert
for Local DNS and Local CNAME pages.
#2203
Conversation
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it but I never get the success
message (but action is performed successfully).
Additionally, (even if not the main concern of this PR) it would be nice if the input fields were cleaned after action was performed.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the fields should be cleaned after something is deleted. A use case would be adding in data already, but spotting something to delete first, which would trigger the cleaning
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
The missing success message was due to a FTL resolver startup delay configured by |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1 |
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Fix #1357.
How does this PR accomplish the above?:
Replacing individual local functions with the global
utils.showAlert
function.What documentation changes (if any) are needed to support this PR?:
none.