Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct endpoint for MAXLOGAGE #2216

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Use the correct endpoint for MAXLOGAGE #2216

merged 1 commit into from
Jun 1, 2022

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix the response of api.php?getMaxlogage
The response for this call was always returning the default value (24), because it was not asking for the correct information.

How does this PR accomplish the above?:

The API call now receives the value of "maxlogage" from FTL, as expected.

What documentation changes (if any) are needed to support this PR?:

none.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser yubiuser merged commit 37baf60 into devel Jun 1, 2022
@yubiuser yubiuser deleted the fix/maxlogage branch June 1, 2022 05:59
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants