Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default FTL log file path to /var/log/pihole/FTL.log #2244

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 3, 2022

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

This is a follow-up of pi-hole/pi-hole#3732 changing FTL's default log file path from /var/log/pihole/pihole-FTL.log to the slightly shorter /var/log/pihole/FTL.log

  • How does this PR accomplish the above?:

Replace the file path

  • What documentation changes (if any) are needed to support this PR?:

Nothing special, we already covered that files moved into /var/log/pihole


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

…g to /var/log/pihole/FTL.log

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team July 3, 2022 18:28
@yubiuser yubiuser merged commit 032d0db into devel Jul 3, 2022
@yubiuser yubiuser deleted the tweak/default_log_path branch July 3, 2022 20:20
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants