Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tailLog.php looks like pihole -t #2263

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Make tailLog.php looks like pihole -t #2263

merged 2 commits into from
Jul 14, 2022

Conversation

rdwebdesign
Copy link
Member

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

To use in the web interface taillog the same highlighting used by pihole -t.

  • How does this PR accomplish the above?:

This PR adds different formats to specific log lines.

  • What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team July 13, 2022 04:35
@yubiuser
Copy link
Member

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pihole -t also strips off dnsmasq and the date. Did you leave this on purpose?

Bildschirmfoto zu 2022-07-13 22-35-28

@rdwebdesign
Copy link
Member Author

Yes.
I didn't think there was a need to remove the dnsmasq[nnn] part.
I also see no reason to remove the day and month from the date.

@rdwebdesign rdwebdesign marked this pull request as draft July 13, 2022 20:55
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign marked this pull request as ready for review July 13, 2022 22:30
@yubiuser yubiuser merged commit 09fbd8b into devel Jul 14, 2022
@yubiuser yubiuser deleted the tweak/taillog branch July 14, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants