Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused client_id #2267

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Remove unused client_id #2267

merged 1 commit into from
Jul 17, 2022

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Fixes an issue that was introduced by #2202.
This PR added a few columns from the query_storage table of the long-term database to the output of web interface. However, one column does not exist (client_id). (Probably a leftover from testing the code).

Using the web interface right now results in this error:

2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127
2022-07-16 14:38:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice:  Undefined index: client_id in /var/www/html/admin/api_db.php on line 127

This PR removes the unused line.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jul 16, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/undefined-array-key-client-id-in-api-db-php/56587/3

@DL6ER DL6ER added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Jul 17, 2022
@DL6ER DL6ER merged commit e3fa874 into devel Jul 17, 2022
@DL6ER DL6ER deleted the fix/long_term branch July 17, 2022 09:01
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/undefined-array-key-client-id-in-api-db-php/56587/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants