Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore save functionality #2308

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Restore save functionality #2308

merged 1 commit into from
Aug 23, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 23, 2022 •
edited
Loading

What does this PR aim to accomplish?:

#2301 Removed too much code, including the hidden input fields. This prevents to change the theme. This fixes this be just re-adding the removed code.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Restore save functionality
cda98e2 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team August 23, 2022 07:10
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Aug 23, 2022
@yubiuser yubiuser merged commit 74df830 into devel Aug 23, 2022
@yubiuser yubiuser deleted the fix/save_settings branch August 23, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

Assignees
No one assigned
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yubiuser @rdwebdesign