Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpretation for Pi-hole message type ADLIST #2320

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Sep 1, 2022

  • What does this PR aim to accomplish?:

Accompany pi-hole/FTL#1415.

  • How does this PR accomplish the above?:

Adding code necessary to pretty-print ADLIST database messages.

Example:
Bildschirmfoto zu 2022-09-01 09-02-16

It also adds the code to link back to a specific adlistid by re-using code from a97f52a

  • What documentation changes (if any) are needed to support this PR?:

None


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/gravity-update-timeout/57391/28

@yubiuser yubiuser force-pushed the adlist_message branch 3 times, most recently from 5f4f884 to 1933028 Compare September 1, 2022 07:16
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux PromoFaux merged commit aa529a7 into devel Sep 14, 2022
@PromoFaux PromoFaux deleted the adlist_message branch September 14, 2022 19:16
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-web-v5-15-and-core-v5-12-1-released/57894/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants